Factor out the local NAR cache into its own class #14997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
store
xokdvium
reviewed
Jan 15, 2026
|
|
||
| std::filesystem::path NarCache::makeCacheFile(const Hash & narHash, const std::string & ext) | ||
| { | ||
| return (cacheDir / narHash.to_string(HashFormat::Nix32, false)) + "." + ext; |
Contributor
There was a problem hiding this comment.
Hm I think this will fail to build on MinGW. See ccdd1f1
Member
|
Yeah I would like the division of labor to be a bit different, I will take a stab a it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This prepares allowing the NAR cache to be used for substitution (see DeterminateSystems#279).
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.